[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13460 [Tor Browser]: fix error handling mistake in patch for Bug 13028

#13460: fix error handling mistake in patch for Bug 13028
-----------------------------+---------------------------------------------
     Reporter:               |      Owner:
  arthuredelstein            |     Status:  closed
         Type:  defect       |  Milestone:
     Priority:  normal       |    Version:
    Component:  Tor Browser  |   Keywords:  MikePerry201410R, tbb-4.5-alpha
   Resolution:  fixed        |  Parent ID:
Actual Points:               |
       Points:               |
-----------------------------+---------------------------------------------
Changes (by mikeperry):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Couple points:

 1. In one of those two cases, I used the return because the normal error
 handling had a free for a strdup. We need to move the block above the
 strdup if we want to use it.
 2. Your fixup commits need to have the full commit summary line that they
 are fixing, otherwise git won't autosquash them together when we rebase.

 I've fixed both of these issues and pushed this commit:
 https://gitweb.torproject.org/tor-
 browser.git/commitdiff/6cb68a4ec0990509273a939c2034c20aa26ff69d.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13460#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs