[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13019 [Tor Browser]: New locale fingerprinting capabilities in FF31ESR



#13019: New locale fingerprinting capabilities in FF31ESR
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  tbb-team
  mikeperry              |     Status:  reopened
         Type:  defect   |  Milestone:
     Priority:  major    |    Version:
    Component:  Tor      |   Keywords:  ff31-esr, tbb-fingerprinting,
  Browser                |  MikePerry201409R, TorBrowserTeam201410,
   Resolution:           |  tbb-4.5-alpha
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------
Changes (by gk):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Replying to [comment:12 mikeperry]:
 > It looks like there's a new memory leak in that patch. You were
 strdupping an already strdupped pointer from JS_GetDefaultLocale().
 >
 > I fixed this in a fixup commit.

 This seems to break the build:
 {{{
 /home/ubuntu/build/tor-browser/xpcom/build/nsXPComInit.cpp: In function
 'void {anonymous}::StartWatchingDefaultLocalePref()':
 /home/ubuntu/build/tor-browser/xpcom/build/nsXPComInit.cpp:496:39: error:
 invalid conversion from 'const char*' to 'char*' [-fpermissive]
      sJSLocale = JS_GetDefaultLocale(rt);
                                        ^
 make[5]: *** [nsXPComInit.o] Error 1
 make[5]: Leaving directory `/home/ubuntu/build/tor-browser/obj-i686-pc-
 linux-gnu/xpcom/build'
 make[4]: *** [xpcom/build/compile] Error 2
 make[4]: *** Waiting for unfinished jobs....
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13019#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs