[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17183 [Tor]: Add exit-policy/reject-private so stem can discover ExitPolicyRejectPrivate rules

#17183: Add exit-policy/reject-private so stem can discover ExitPolicyRejectPrivate
rules
-----------------------------+--------------------------------
     Reporter:  teor         |      Owner:
         Type:  enhancement  |     Status:  needs_revision
     Priority:  normal       |  Milestone:  Tor: 0.2.8.x-final
    Component:  Tor          |    Version:  Tor: unspecified
   Resolution:               |   Keywords:  stem, 028-triaged
Actual Points:               |  Parent ID:
       Points:  small        |    Sponsor:
-----------------------------+--------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Quick review:
   * Looks mostly good; glad to see tests.
   * we never use strcat in Tor: too many linkers and security tools shout
 about it. Instead I'd just suggest you use `smartlist_add_asprintf()` in
 the inner loop. It's waaay less error-prone.
   * There needs to be a corresponding control-spec.txt patch.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17183#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs