[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #12967 [Tor Launcher]: Support a multi-lingual TBB that can switch between localizations
#12967: Support a multi-lingual TBB that can switch between localizations
-------------------------------------------------+-------------------------
Reporter: mikeperry | Owner: mcs
Type: enhancement | Status:
Priority: High | needs_review
Component: Tor Launcher | Milestone:
Severity: Normal | Version:
Keywords: tbb-usability-stopppoint-wizard, | Resolution:
TorBrowserTeam201510R | Actual Points:
Parent ID: #17304 | Points:
Sponsor: SponsorU |
-------------------------------------------------+-------------------------
Comment (by gk):
Replying to [comment:21 mcs]:
> The "builder" changes are here:
> https://gitweb.torproject.org/user/brade/tor-browser-
bundle.git/commit/?h=bug12967-01&id=6e1ecb2662b2cbcd6e4f1ee4635ca8fc4924c387
>
> Please review (using -w makes for much smaller diffs). Feedback is
welcome, especially for the way Kathy and I use "ALL" as a locale within
the package filenames and when fetching the update manifests. I think it
is a good solution, but someone else may have a better idea.
This looks good. Some things I have:
What about "generic"? Or what about "" (like tor-browser-
linux64-5.5a4.tar.xz) given that we only include the locales in the
package names as we ship differently localized bundles. If that is not
done anymore not confusing the user with either "ALL" or "generic" or ...
might be a good option?
I think we should do the changes to the `versions.nightly` first. If the
patches stick in a nightly build we can use them for `versions.alpha` etc.
as soon as we tag a tor-launcher version.
It appears to me we only need one `cd mac-langpacks`/`cd
win32-langpacks`/`cd linux-langpacks` if we move them at the beginning of
the respective `for`-loop?
s/package names/package name/ (there is just one package with all locales)
Linux
-----
"packages" -> "package" (we plan to create only one)
whitespace between "popd" and "Set the update.locale"
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12967#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs