[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #19459 [Applications/Tor Browser]: Write (C++) patch for window resizing parts



#19459: Write (C++) patch for window resizing parts
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  arthuredelstein
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton-conversion,            |  Actual Points:
  TorBrowserTeam201610R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorU
-------------------------------------------------+-------------------------
Changes (by arthuredelstein):

 * keywords:  tbb-torbutton-conversion, TorBrowserTeam201610 => tbb-
     torbutton-conversion, TorBrowserTeam201610R
 * status:  needs_revision => needs_review


Comment:

 Ouch, I'm admitting a humiliating defeat and switching to a C++ patch. :(
 I honestly thought a JavaScript patch was the right way to go, but it was
 not to be.

 I tested this patch on Windows, Debian/xfce4 and OS X. It seems to be
 working on all 3.

 https://github.com/arthuredelstein/tor-browser/commit/19459+10

 I've left in some commented-out printf statements because they are highly
 useful for debugging. But we can remove them in the final version if it
 all looks OK.

--
Ticket URL: <https://troodi.torproject.org/projects/tor/ticket/19459#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs