[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #19459 [Applications/Tor Browser]: Write (C++) patch for window resizing parts



#19459: Write (C++) patch for window resizing parts
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  arthuredelstein
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton-conversion,            |  Actual Points:
  TorBrowserTeam201610R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorU
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:33 arthuredelstein]:
 > I was able to reproduce this problem on a Windows machine and fixed it
 by adding a little piece of the old JS patch. It's annoying to me to have
 to add special-case code to two different files, but there is so much
 magic in Firefox window sizing that I don't know how else to do it. I
 wonder if this patch fixes the problem on your test system as well.
 >
 > Here's the new version:
 > ​https://github.com/arthuredelstein/tor-browser/commit/19459+13

 It does, neat! One nit: could you put a comment above the JS code change
 explaining what is going on? (maybe pointing to #18175 additionally?)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19459#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs