[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #20284 [Core Tor/Tor]: consensus weight case 2b3 does not follow dir-spec
#20284: consensus weight case 2b3 does not follow dir-spec
-----------------------------+------------------------------------
Reporter: pastly | Owner: pastly
Type: defect | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: review-group-11 | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-----------------------------+------------------------------------
Comment (by teor):
I wonder if the name `networkstatus_compute_bw_weights_v10` is confusing
after this change.
What it used to mean was: 'compute bandwidth weights using the method
introduced at consensus method 10'. Now it means: 'if the consensus_method
parameter is < 27, use the method introduced at consensus method 10,
otherwise, use the method introduced at consensus method 27'.
Maybe we could drop the v10 from the name, and document those semantics in
the function header?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20284#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs