[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #23862 [Core Tor/Tor]: Tor only updates guard state after a consensus if it has enough directory info



#23862: Tor only updates guard state after a consensus if it has enough directory
info
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  asn
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.0.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-guard, tor-bridge, tor-client,   |  Actual Points:
  030-backport, 031-backport                     |
Parent ID:  #21969                               |         Points:  1
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorV
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  assigned => needs_review


Comment:

 Please see branch `bug23862_v2` in my repo that features the following
 changes from teor's branch:
 - Rebased to latest master
 - Added unittest that reproduces the failure and makes sure that the patch
 fixes it.
 - Add changes file
 - Add some more info on the commit msgs.

 The unittest was not simple to right at all due to the hairiness of the
 subsystems involved (mds and guards)!!! It took me about 6 hours to write
 and I encountered another bug while writing it (#23989). Let me know if
 you have any questions.

 FWIW, I don't think this bug is a very important bug wrt #21969. It's
 quite edge-casey and it won't cause a total client disable like #21969.
 Onwards!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23862#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs