[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27320 [Applications/Tor Browser]: Build certutil for Windows



#27320: Build certutil for Windows
--------------------------------------+--------------------------------
 Reporter:  JeremyRand                |          Owner:  tbb-team
     Type:  enhancement               |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-rbm                   |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------------

Comment (by JeremyRand):

 > I am not convinced yet that we need to include libssp-0.dll yet. If you
 check the included binaries in the mar-tools directory there is non that
 has stack_chk* in it. (see: comment:11:ticket:15138) Compare that to the
 output you get from checking the binaries in tor-browser_en-
 US\Browser\TorBrowser\Tor. (I think that's due to us using
 LDFLAGS="$LDFLAGS -static" for our mingw-w64 builds for the browser part)

 You are correct; I just tested the binaries I built, and certutil.exe
 works fine with libssp-0.dll removed (I tested creation of a database and
 listing the certs from nssckbi.dll).  I haven't tested the other programs,
 but I'll take your word for it that they don't need it either.  I'll make
 that change and then rebase against master, hopefully later today.  Thanks
 for catching that!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27320#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs