[tor-bugs] #28011 [Core Tor/Tor]: shellcheck: run_calltool.sh issues

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#28011: shellcheck: run_calltool.sh issues
------------------------------+--------------------
     Reporter:  rl1987        |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------
 Shellcheck (​​​​​https://github.com/koalaman/shellcheck) finds the
 following issues:

 {{{
 In run_calltool.sh line 18:
   python -m calltool $calculation > callgraph/$calculation
                      ^-- SC2086: Double quote to prevent globbing and word
 splitting.
                                               ^-- SC2086: Double quote to
 prevent globbing and word splitting.


 In run_calltool.sh line 21:
 echo <<EOF > callgraph/README
 ^-- SC2217: Redirecting to 'echo', a command that doesn't read stdin. Bad
 quoting or missing xargs?

 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28011>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs