[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27947 [Core Tor/Tor]: Chutney's owning controller process code compares strings with ints



#27947: Chutney's owning controller process code compares strings with ints
--------------------------+--------------------------
 Reporter:  teor          |          Owner:  teor
     Type:  defect        |         Status:  assigned
 Priority:  Medium        |      Milestone:
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+--------------------------

Comment (by opara):

 Would you be okay with a patch that moves these lines out of the
 `TorNet.py` file and into the `test-network.sh` script? It would make more
 sense to me to keep these out of `TorNet.py` since these three environment
 variables don't seem relevant to Chutney as a whole, but more just for the
 test network script.

 On the other hand there may be reasons why they were put in `TorNet.py`,
 and in that case, I can submit a patch which fixes the problem directly
 (wraps the `os.environ.get()` in an `int()` call).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27947#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs