[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  task          |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  042-can       |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  teor          |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Design review:

 The design and overall structure looks good. I am not that familiar with
 coccinelle, so I will need to run these scripts myself as part of my
 review.

 Should we be running these scripts as part of our code quality checks?
 (We could install coccinelle on Travis, so it runs them.)
 Is that a separate ticket?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31705#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs