[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus



#31684: Add control port GETINFO support for dumping the local consensus
--------------------------------------------+------------------------------
 Reporter:  asn                             |          Owner:  (none)
     Type:  task                            |         Status:  needs_review
 Priority:  Medium                          |      Milestone:  Tor:
                                            |  0.4.3.x-final
Component:  Core Tor/Tor                    |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  control-port easy extra-review  |  Actual Points:
Parent ID:                                  |         Points:  1
 Reviewer:  asn                             |        Sponsor:
--------------------------------------------+------------------------------
Changes (by asn):

 * keywords:  control-port easy => control-port easy extra-review


Comment:

 Thanks. Two more minor issues and we are done.

 I also tested that this works fine with a stem script that looks like
 this:
 {{{
  controller = Controller.from_port(port=9090)
  controller.authenticate()
  ns = controller.get_info("dir/status-vote/current/consensus-microdesc")
  print("microdesc: %s" % ns)
  ns = controller.get_info("dir/status-vote/current/consensus")
  print("ns: %s" % ns)
 }}}

 After you change these two minor issues please mark it as `merge_ready`.

 Marking as extra review so that the merger checks that the issues have
 been fixed before merging (I will be away for two weeks)

 Thanks again for the code!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31684#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs