[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30461 [Applications/Tor Browser]: Update tor-android-service Project to Use Android Toolchain (Firefox 68)
#30461: Update tor-android-service Project to Use Android Toolchain (Firefox 68)
-------------------------------------------------+-------------------------
Reporter: sisbell | Owner: tbb-
| team
Type: defect | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-rbm, ff68-esr, tbb-9.0-must- | Actual Points:
alpha, TorBrowserTeam201910 |
Parent ID: #30324 | Points:
Reviewer: | Sponsor:
| Sponsor44-can
-------------------------------------------------+-------------------------
Comment (by gk):
Replying to [comment:34 sisbell]:
> From a tor-android-service, mavenLocal is not directly needed but it
doesn't hurt to add it directly to the gradle build file for tor build.
What do you mean? If it's not needed then why do we have the additional
complexity? If it *is* needed then it seems to me supporting the Tor build
case directly in `tor-android-service` is a plus. Other folks might want
to build `tor-android-service` the same way as we.
> Replying to [comment:33 gk]:
> > Thanks this looks better. Why are we shipping the `maven-local.patch`
and do not add this change to our repo directly? If we add `mavenLocal()`
as last item then there should not be a functional difference to the
status quo for projects fetching the dependencies from any of the other
specified repositories.
> >
> > There are still the tickets to file.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30461#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs