[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32124 [Core Tor/Tor]: Interpret --disable-module-dirauth=no correctly

#32124: Interpret --disable-module-dirauth=no correctly
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  assigned
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.4.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  network-team-roadmap-october, tor-   |  Actual Points:
  build, no-backport?                            |
Parent ID:  #32123                               |         Points:  0.1
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor31-can
-------------------------------------------------+-------------------------
Description changed by teor:

Old description:

> Currently, we treat --disable-module-dirauth=no as enabling the C macro,
> but disabling the Makefile variable.
>
> Apparently lots of people make this mistake:
> {{{
> The most common mistake for this macro is to consider the two actions as
> action-if-enabled and action-if-disabled.
>
> This is not the case!
>
> Since using --disable-foo or --enable-foo=no are equivalent, for the
> macro, you cannot really use this macro with those meanings.
> }}}
>
> I don't know if we should backport this change, it just didn't work
> before, so maybe it should just go in master?

New description:

 Currently, we treat --disable-module-dirauth=no as enabling the C macro,
 but disabling the Makefile variable.

 Apparently lots of people make this mistake:
 {{{
 The most common mistake for this macro is to consider the two actions as
 action-if-enabled and action-if-disabled.

 This is not the case!

 Since using --disable-foo or --enable-foo=no are equivalent, for the
 macro, you cannot really use this macro with those meanings.
 }}}
 https://autotools.io/autoconf/arguments.html

 I don't know if we should backport this change, it just didn't work
 before, so maybe it should just go in master?

--

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32124#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs