[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32175 [Core Tor/Tor]: test_options.c uses some very wonky options objects.



#32175: test_options.c uses some very wonky options objects.
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  merge_ready
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  .2
Parent ID:  #31241        |         Points:
 Reviewer:                |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => merge_ready
 * reviewer:  teor =>


Comment:

 Looks great, I am so happy we are finally cleaning up these tests.

 Some of the mass replaces would have been better as scripts, but they all
 look fine.

 Ready for merge, as soon as CI passes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32175#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs