[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31919 [Core Tor/Tor]: Add a check-local target that runs our coccinelle parsing problems script
#31919: Add a check-local target that runs our coccinelle parsing problems script
--------------------------+------------------------------------
Reporter: teor | Owner: (none)
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: 042-can | Actual Points: 0.3
Parent ID: #31705 | Points: 0.5
Reviewer: nickm | Sponsor:
--------------------------+------------------------------------
Comment (by teor):
Replying to [comment:5 nickm]:
> Quick comment on patch:
>
> I'm not 100% sure about requiring everybody to install coccinelle for
them to be able to run the pre-commit hook.
If spatch is not installed, the script logs a message and exits without
error:
https://github.com/torproject/tor/pull/1454/commits/616bc21859c50f75e0f1092cab0dca0de62f47b9
#diff-e4d63afb05764cd8a5149d2f09edd87dR21
I'm not entirely happy with the speed of spatch, but let's see how it
goes. Maybe there's some nice way to do it in parallel.
I'm making progress on this, just doing performance checks now.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31919#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs