[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
[tor-bugs] #32334 [Core Tor/Tor]: do not throw enable_tool_name_check error when compiling for Android and iOS
#32334: do not throw enable_tool_name_check error when compiling for Android and
iOS
--------------------------+------------------------------
Reporter: eighthave | Owner: (none)
Type: enhancement | Status: new
Priority: Medium | Component: Core Tor/Tor
Version: | Severity: Normal
Keywords: Android, iOS | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------+------------------------------
This check only fails when building for Android and iOS, it does not do
something useful there. So when compiling for Android or iOS, it should
be disabled by default. Or perhaps even better: it should only be enabled
on platforms where it is useful. The Guardian Project, Thali, and Briar
Android builds have always used --disable-name-tool-check. The iCepa
Tor.framework also does.
Some examples:
* LarryBitcoin:
https://trac.torproject.org/projects/tor/ticket/31552#comment:4
* n8fr8: https://trac.torproject.org/projects/tor/ticket/31301#comment:2
* iCepa Tor.framework:
https://github.com/iCepa/Tor.framework/blob/30480101b3bd2166baced913347fc8bb7392b3da/Tor/tor.sh#L139
* tor-android: https://github.com/guardianproject/tor-
android/blob/0830c87a29ea197ecd9a0b5aee7d9a4fb88dce25/external/Makefile#L271
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32334>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs