[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #1954 [Tor Client]: LoadLibrary used without restrictions for search path

#1954: LoadLibrary used without restrictions for search path
------------------------+---------------------------------------------------
 Reporter:  Sebastian   |       Owner:                    
     Type:  defect      |      Status:  needs_review      
 Priority:  major       |   Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |     Version:                    
 Keywords:              |      Parent:                    
------------------------+---------------------------------------------------

Comment(by Sebastian):

 {{{
 +  TCHAR path[MAX_PATH];
 +  unsigned n;
 +  n = GetSystemDirectory(path, 1024);
 }}}

 that looks weird. MAX_PATH once, then 1024?

 Also you'll want to remove these two XXX I think:
 {{{
    /* XXXX Possibly, we should hardcode the location of this DLL. */
 }}}

 I'm not done reviewing but am running of for a bit.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1954#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs