[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #4341 [Tor]: MyFamily Option Requires a Dollar Sign "$"
#4341: MyFamily Option Requires a Dollar Sign "$"
-------------------------+------------------------------------------
Reporter: marlowe | Owner:
Type: defect | Status: needs_revision
Priority: normal | Milestone: Tor: 0.2.5.x-final
Component: Tor | Version: Tor: 0.2.2.34
Resolution: | Keywords: easy configuration tor-relay
Actual Points: | Parent ID:
Points: |
-------------------------+------------------------------------------
Changes (by nickm):
* status: assigned => needs_revision
* milestone: Tor: unspecified => Tor: 0.2.5.x-final
Comment:
Quick notes:
* We never use strcat or strcpy. Instead, in this case, I'd recommend
tor_asprintf().
* Is the cast to (char * *) still needed after the changed function
signature?
* For loops this long, I recommend SMARTLIST_FOREACH_BEGIN and
SMARTLIST_FOREACH_END.
Otherwise, this looks okay. (As for the earlier question, IMO it doesn't
matter much here whether we change the behavior or improve the error
message in this case.)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4341#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs