[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #3199 [Tor]: Refactor periodic events

#3199: Refactor periodic events
------------------------+------------------------------
     Reporter:  nickm   |      Owner:
         Type:  defect  |     Status:  new
     Priority:  normal  |  Milestone:  Tor: unspecified
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  easy tor-relay
Actual Points:          |  Parent ID:
       Points:          |
------------------------+------------------------------

Comment (by Ry):

 Current implementation has 2 oddities, do we want them mimicked in the
 refactor or not?

 1. All events are initially dispatched after 1 second instead of as soon
 as the main loop is called. (the first call to the run_scheduled_events is
 in the one_second callback)
 2. The timers exhibit an off by one error, e.g. 60 second intervals happen
 every 61 seconds. This is due to checking next < now rather than <=.

 I can mimic these issues if necessary, but I think fixing/simplifying
 these at the same time would be a benefit.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3199#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs