[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #8614 [BridgeDB]: BridgeDB should be able to return multiple transport types at the same time
#8614: BridgeDB should be able to return multiple transport types at the same time
--------------------------+--------------------------
Reporter: asn | Owner:
Type: defect | Status: needs_review
Priority: normal | Milestone:
Component: BridgeDB | Version:
Resolution: | Keywords: important
Actual Points: | Parent ID: #8615
Points: |
--------------------------+--------------------------
Comment (by sysrqb):
Replying to [comment:13 asn]:
> Partial review of `bug8614_5_rebased_r4` follows. Haven't seen
`bug8614_5_rebased_r7` yet.
Thanks
> * `0e91c34375804e0f42ece1b89f26f0db7c1405d4` seems a bit messy. Why
would `transports` be True? Isn't it supposed to be a `pluggable transport
method name` (string?)?
I was overloading the variable, I'm not doing this anymore, hopefully it
is more understandable now.
> * Thanks for the extra docs! Here are two places where I would
appreciate some more docs:
> - I think that there should be some docs on the body of
`getBridgesForIP()` giving an overview of the algorithm used. That
function is pretty important but long, borderline messy (at least there
are tests) and its logic is not apparent.
Done, hopefully it explains the process well enough.
> - Would be nice to have an example of what we are trying to parse in the
docstring of `findORAddrSubstringInBridgeLine()`. Also, what's up with
the `v` variable? Is it like a `debug` variable? Why not just use
`logging.debug()` or the bridgedb equivalent?
Those `v` things are gone, I was using them for debugging but I forgot to
remove them before I pushed. I also added an example of how to use this
function and its output.
> - `if` clauses in `testDistWithFilterTransport()` seem to be the same.
Indeed, I don't remember why this was done. I removed the duplication.
New and improved: see bug8614_6_rebased_1
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8614#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs