[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9157 [BridgeDB]: Persian and Arabic should be right aligned on bridges.tpo

#9157: Persian and Arabic should be right aligned on bridges.tpo
--------------------------+---------------------------------
     Reporter:  runa      |      Owner:  isis
         Type:  task      |     Status:  closed
     Priority:  minor     |  Milestone:
    Component:  BridgeDB  |    Version:
   Resolution:  fixed     |   Keywords:  RTL,translations,ui
Actual Points:            |  Parent ID:
       Points:            |
--------------------------+---------------------------------
Changes (by isis):

 * status:  needs_information => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:18 sysrqb]:
 > Hm, can you retest and see if you can reproduce it? I tested with
 English, Arabic, Hebrew (in that order) and it still rendered LTR. Let me
 know how you break it, so that I can fix it. :)

 I can reproduce the bug if I test your patches on top of the new
 translations that I'm merging, but not if I test your patches on top of
 master -- so I suspect it is a problem with the translation files.

 What is happening is actually that English isn't displaying at
 all...instead it returns the first non-English language in the `Accept-
 Language` list. Here's a screenshot, running from your patches on top of
 the newly merged translations, requesting three types of English, then
 French (the red text is the relevant log lines of the request, it's not
 actually on the page).

 [[Image(9157-english-request.png)]]

 I am inclined to believe that the newly merged translations are messing
 this up, not your patches. And, obviously, the text direction is fine for
 French, so I'm closing this as fixed and possibly opening a new ticket for
 why English, of all things, seems to be missing.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9157#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs