[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13047 [Tor Browser]: Updater should not send Kernel and GTK version

#13047: Updater should not send Kernel and GTK version
-------------------------+-------------------------------------------------
     Reporter:  gk       |      Owner:  mcs
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:
    Component:  Tor      |    Version:
  Browser                |   Keywords:  tbb-firefox-patch
   Resolution:           |  ,TorBrowserTeam201409,MikePerry201409R
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by gk):

 Replying to [comment:7 mcs]:
 > The browser changes are here (bug13047 branch in brade remote):
 >   https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/1aa441fe6408ea1b0e94431f284f0d583a877a2e

 What about writing
 {{{
       let sysInfo = Cc["@mozilla.org/system-info;1"]
                       .getService(Ci.nsIPropertyBag2);
       let osVersion = sysInfo.getProperty("version");
 }}}
 just as
 {{{
       let osVersion = Services.sysinfo.getProperty("version");
 }}}
 ? If that is not an option then using `nsIPropertyBag` should be enough as
 we only need `getProperty()`.

 And, yes, detecting 64/32 bit via `BUILD_TARGET` should do the trick, nice
 catch.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13047#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs