[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13213 [Tor]: Tor should tell its pluggable transports when DisableNetwork gets set/unset



#13213: Tor should tell its pluggable transports when DisableNetwork gets set/unset
------------------------+--------------------------------
     Reporter:  arma    |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  normal  |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-pt
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by yawning):

 Hmm, I think what's done here is correct, at least for the issue at hand,
 and using `net_is_disabled()` will break things.

 The difference between what I'm doing and using the call is that the call
 checks hibernation status, but without additional code to relaunch pts
 that happen to get torn down when coming out of hibernation (and to tear
 down pts when entering hibernation), it's not safe to look at hibernation
 state here.

 What the code below does is delay doing the pt config process (under the
 assumption that you can just
 Now, when entering hibernation, PTs *SHOULD* be torn down, and *SHOULD* be
 relaunched when exiting, but that's requires more invasive code changes,
 and (IMO) is an orthogonal issue.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13213#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs