[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20151 [Core Tor/Tor]: Fix parse_virtual_addr_network minimum network size

#20151: Fix parse_virtual_addr_network minimum network size
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  easy intro    |  Actual Points:
Parent ID:                |         Points:  0.5
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  new => needs_revision


Comment:

 Thanks for this fix!

 Here's what I would change before merging it:
 * rebase on the latest master
   * that is, cherry pick afbda70 onto master, removing dbbd36e and b5b8d62
 - these are merge and fix commits that aren't relevant to the patch
 * keep the newline that's removed from the end of addressmap.c
 * add the smallest network size to the manpage, with a note that larger
 sizes are better :-)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20151#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs