[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #22836 [Metrics/Website]: Parse CollecTor's index.json and provide our own directory listing
#22836: Parse CollecTor's index.json and provide our own directory listing
-----------------------------+-----------------------------
Reporter: karsten | Owner: karsten
Type: enhancement | Status: merge_ready
Priority: Medium | Milestone:
Component: Metrics/Website | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-----------------------------+-----------------------------
Changes (by iwakeh):
* status: needs_review => merge_ready
Comment:
Replying to [comment:18 karsten]:
> Replying to [comment:17 iwakeh]:
> > I cannot find a test for `static List<String[]> formatTableEntries`,
did you forget a commit?
>
> I did not include one, because I didn't find an easy way to test this
method. But I like your new test method and think it already covers this
method quite well. Do you think we need to test more?
Yes, only a different structure made ease of testing possible. If there
had been another test, I would have suggested merging the test data.
In general, there are never enough tests ;-) All fine, until the next bug
is discovered.
> ...
>
> I only made a few trivial tweaks in
[https://gitweb.torproject.org/karsten/metrics-web.git/log/?h=task-22836
my updated task-22836 branch] that is based on yours. If you like them, do
you mind me squashing all commits into one before rebasing and pushing to
master?
All fine.
Ready for merge!
>
> Thanks for the review and improvements!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22836#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs