[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27439 [Applications/Tor Browser]: Configure Rust compiler to target Android Platform



#27439: Configure Rust compiler to target Android Platform
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-mobile,                 |  Actual Points:
  TorBrowserTeam201809                           |
Parent ID:  #26693                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by boklm):

 * keywords:  tbb-rbm, tbb-mobile, TorBrowserTeam201809R => tbb-rbm, tbb-
     mobile, TorBrowserTeam201809
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:2 sisbell]:
 > commit: https://github.com/sisbell/tor-browser-
 build/commit/2b5fa20f153d6ce708ab9043f2a5254f66ea9d7e

 Some comments:
 - instead of defining `prev_rust` twice (for android, and for other
 platforms), it is possible to define a variable `var/rust_arch` which
 defaults to `var/arch`, except on android where we set it to `x86_64`. The
 `var/rust_arch` variable can then be used in the `prev_rust` url, and the
 directory name in `rust/build`.
 - `android-toolchain` should not need to be listed in the dependencies, if
 it is set as `var/compiler` (after the change is done in #26696), as
 `var/compiler` is already listed in the dependencies.
 - the setup of the android toolchain should not be done in
 `projects/rust/build`, but in `var/setup` defined in `project/android-
 toolchain/config`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27439#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs