[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26146 [Applications/Tor Browser]: Setting `general.useragent.override` does not spoof the platform part anymore in ESR 60 which is confusing



#26146: Setting `general.useragent.override` does not spoof the platform part
anymore in ESR 60 which is confusing
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  mcs
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff60-esr, tbb-fingerprinting-os,     |  Actual Points:
  tbb-8.0-issues, tbb-8.0.1-can,                 |
  TorBrowserTeam201809R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:58 mcs]:
 > Here is a patch for review:
 > https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug26146-01&id=c8751602f218f40ff243d63de8e8fbcc7e651230
 > Please read the commit message to learn what it does.

 Looks mostly good to me. I guess we could refactor
 `Navigator::GetUserAgent()` a bit but we can leave that our for now and
 tackle that when upstreaming this patch.

 Please adjust the WinXP in the commit message and the title given that you
 delete `general.useragent.override` from the prefs we ship but have the
 bug fixed nevertheless. Maybe "Bug 26146: Spoof HTTP User-Agent header for
 desktop platforms"? (or something like that). Oh, and that's not only
 JavaScript on/off related. The risk we are writing the patch for is that
 the OS is collected by any server Tor Browser is talking to, irrespective
 of your JS settings.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26146#comment:63>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs