[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27543 [Applications/Tor Browser]: QR code on http://web.whatsapp.com is only shortly visible in Tor Browser 8



#27543: QR code on http://web.whatsapp.com is only shortly visible in Tor Browser 8
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,      |  Actual Points:
  tbb-8.0.1-can, GeorgKoppen201809,              |
  TorBrowserTeam201809R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 It seems a simple patch like
 {{{
 diff --git a/browser/base/content/browser.js
 b/browser/base/content/browser.js
 index 443619533567..85be5923c509 100644
 --- a/browser/base/content/browser.js
 +++ b/browser/base/content/browser.js
 @@ -6855,23 +6855,23 @@ var CanvasPermissionPromptHelper = {
                      : Ci.nsIPermissionManager.EXPIRE_SESSION);
      }

 -    let mainAction = {
 +    let secondaryActions = [{
        label: gNavigatorBundle.getString("canvas.allow"),
        accessKey: gNavigatorBundle.getString("canvas.allow.accesskey"),
        callback(state) {
          setCanvasPermission(Ci.nsIPermissionManager.ALLOW_ACTION,
                              state && state.checkboxChecked);
        }
 -    };
 +    }];

 -    let secondaryActions = [{
 +    let mainAction = {
        label: gNavigatorBundle.getString("canvas.notAllow"),
        accessKey: gNavigatorBundle.getString("canvas.notAllow.accesskey"),
        callback(state) {
          setCanvasPermission(Ci.nsIPermissionManager.DENY_ACTION,
                              state && state.checkboxChecked);
        }
 -    }];
 +    };
 }}}
 would fix that part.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27543#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs