[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31629 [Core Tor/Tor]: Remove non-_ex typedvar.c function



#31629: Remove non-_ex typedvar.c function
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  task                                 |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  network-team-roadmap-august, asn-    |  Actual Points:
  merge, dgoulet-merge                           |
Parent ID:  #29211                               |         Points:  0
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:  network-team-roadmap-august => network-team-roadmap-august,
     asn-merge, dgoulet-merge
 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:1 nickm]:
 > I have a branch `ticket31629` with a PR at
 https://github.com/torproject/tor/pull/1295 .
 >
 > There is no changes file here, since it contains no changes beyond those
 already contained in earlier commits.  There are two commits: one is pure
 code removal, and the other is automatically generated function renaming.
 >
 > I'll put this in needs_review once CI passes.

 Looks fine to me, I confirmed the second commit using the script:
 {{{
 $ find src -name *.c -o -name *.h | xargs /usr/bin/perl -w -i -p -e
 's{typed_var_(assign|free|encode|copy|eq|ok|kvassign|kvencode|mark_fragile)_ex}{typed_var_$1}g;'
 $ git diff nickm/ticket31629
 }}}

 CI passed, and I am also happy with the coverage:
 > 24 of 26 (92.31%) changed or added relevant lines in 2 files are
 covered.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31629#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs