[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-bugs] #31854 [Core Tor/Tor]: In tests and log.c, stop using ~0 a log domain mask



#31854: In tests and log.c, stop using ~0 a log domain mask
------------------------------+--------------------------------------
     Reporter:  nickm         |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.4.2.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  042-should easy fast-fix
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------------
 There are a few places in the tests where we use ~0 or ~0u to indicate a
 log domain mask that covers all domains.  We also do this in log.c.

 But back in #31080, we made the log_domain_mask_t into a 64-bit value,
 probably one defined by a macro like LD_ALL_DOMAINS.

 Additionally, we should ''not'' use ~(uint64_t)0 for the definition of
 this value, since we don't want to include LD_NO_MOCK, LD_NOCB, and
 LD_NOFUNCNAME.

 Found while looking at #31334; this should be done after #31334 is merged.

 No backport needed, since we do not yet have any logging domains that use
 the high 32 bits of this type.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31854>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs