[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31794 [Circumvention/Snowflake]: Errors swallowed



#31794: Errors swallowed
-------------------------------------+--------------------------------
 Reporter:  sah                      |          Owner:  (none)
     Type:  defect                   |         Status:  needs_revision
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:  cohosh                   |        Sponsor:
-------------------------------------+--------------------------------

Comment (by sah):

 I've completed the changes, and put the commits into a branch which can be
 found at https://github.com/shaneHowearth/snowflake/tree/linter-fixes

 Note also: I renamed variables a and b to WebRTC and ORPort in the places
 they are used, to improve understanding of the code.

 Once these changes are merged then running golangci-lint should be clear
 *except* for issues with client/lib/lib_test.go (I originally fixed the
 issue, but this caused the tests to fail, which alerted me to the test
 coverage of the project, which I intend on looking at in another ticket)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31794#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs