Re: [tor-bugs] #31391 [Circumvention/Snowflake]: Do a reachability check before polling for clients

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#31391: Do a reachability check before polling for clients
-------------------------------------+-----------------------------
 Reporter:  cypherpunks              |          Owner:  arlolra
     Type:  defect                   |         Status:  merge_ready
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:  cohosh                   |        Sponsor:
-------------------------------------+-----------------------------
Changes (by cohosh):

 * status:  needs_review => merge_ready


Comment:

 The code looks good to me, and is ready to merge. I like the refactoring
 changes you made the websocket class and putting both missingFeature
 checks in the initToggle.

 I tested this out and it looks great. I like that in addition to
 displaying the message, it also prevents the user from retrying to enable
 the webextension. However, I'm wondering about the use case in which a
 user sees the message that WebRTC has been disabled, goes into their
 about:config to enable it, and then cannot redo the check without
 restarting their web browser.

 Perhaps a solution to any possible confusion here or with the error
 messages in general would be a short FAQ section for all of our missing
 feature error messages on snowflake.torproject.org (which the user arrives
 at by clicking on the "Learn more" link).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31391#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs