[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [chutney/master] shellcheck: Disable SC1117: backslash escaping



commit dc4a018b05f324cbdd9e4ac49474f2ad8a8ad87c
Author: teor <teor@xxxxxxxxxxxxxx>
Date:   Mon Apr 8 15:10:28 2019 +1000

    shellcheck: Disable SC1117: backslash escaping
    
    SC1117 was disabled after shellcheck release 0.5, because it was
    too pedantic.
    
    But shellcheck 0.5.0 is still in the Travis Homebrew cache.
    
    So we disable SC1117 in shellcheck-tests.sh.
    
    Part of 30065.
---
 tests/shellcheck-tests.sh | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/tests/shellcheck-tests.sh b/tests/shellcheck-tests.sh
index 02afbaa..b24a770 100755
--- a/tests/shellcheck-tests.sh
+++ b/tests/shellcheck-tests.sh
@@ -5,6 +5,8 @@ set -e
 # Verbose mode
 set -v
 
+# SC1117 was disabled after 0.5, because it was too pedantic
+EXCLUSIONS="--exclude=SC1117"
 
 # Output is prefixed with the name of the script
 myname=$(basename "$0")
@@ -17,7 +19,8 @@ echo "$myname: changing to chutney directory"
 cd "$CHUTNEY_DIR"
 
 
-echo "$myname: running shellcheck tests"
+echo "$myname: running shellcheck tests with $EXCLUSIONS"
 
-shellcheck chutney
-find . -name "*.sh" -exec shellcheck {} +
+shellcheck "$EXCLUSIONS" chutney
+
+find . -name "*.sh" -exec shellcheck "$EXCLUSIONS" {} +



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits