[tor-commits] [tor/master] Document check for 30176, since it's a bit subtle.

[dgoulet@xxxxxxxxxxxxxx]

commit 82a3161c41e2c8d8d800a8c645a93b81bd8b2278
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Mon Apr 15 14:52:08 2019 -0400

    Document check for 30176, since it's a bit subtle.
---
 src/test/test_containers.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/test/test_containers.c b/src/test/test_containers.c
index ad272eeaf..67ba45797 100644
--- a/src/test/test_containers.c
+++ b/src/test/test_containers.c
@@ -1006,6 +1006,9 @@ test_container_smartlist_remove(void *arg)
   tt_ptr_op(smartlist_get(sl, 1), OP_EQ, &array[2]);
   tt_ptr_op(smartlist_get(sl, 2), OP_EQ, &array[1]);
   tt_ptr_op(smartlist_get(sl, 3), OP_EQ, &array[2]);
+  /* Ordinary code should never look at this pointer; we're doing it here
+   * to make sure that we really cleared the pointer we removed.
+   */
   tt_ptr_op(sl->list[4], OP_EQ, NULL);
 
  done:



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits