[tor-commits] [tor-browser] 182/311: Bug 1759432 - Don't check for the WebVR pref in VRProcessChild::Init. r=jgilbert a=dmeehan

[gitolite role <git@xxxxxxxxxxxxxxxxxxxxx>]

This is an automated email from the git hooks/post-receive script.

pierov pushed a commit to branch geckoview-99.0.1-11.0-1
in repository tor-browser.

commit 5cec09726d43f6151124cfd26a3050b9049f3f58
Author: Andrew McCreight <continuation@xxxxxxxxx>
AuthorDate: Wed Mar 16 14:36:39 2022 +0000

    Bug 1759432 - Don't check for the WebVR pref in VRProcessChild::Init. r=jgilbert a=dmeehan
    
    This check seems to fail even if the VR pref is enabled. I think this is
    because we are running this code while very early in process startup.
    I think it will not introduce risk because the other process in this case
    will be the parent process, so if that's been taken over then we've already
    lost.
    
    This also seems to fix the leak that I had to ignore before, probably
    because the VR process wasn't even starting up properly before, so I've
    removed the leak threshold I had to add.
    
    Differential Revision: https://phabricator.services.mozilla.com/D141170
---
 gfx/vr/ipc/VRProcessChild.cpp               | 5 -----
 testing/web-platform/meta/webvr/__dir__.ini | 1 -
 2 files changed, 6 deletions(-)

diff --git a/gfx/vr/ipc/VRProcessChild.cpp b/gfx/vr/ipc/VRProcessChild.cpp
index 88fde06a2ac81..1559c393ffb2d 100644
--- a/gfx/vr/ipc/VRProcessChild.cpp
+++ b/gfx/vr/ipc/VRProcessChild.cpp
@@ -30,11 +30,6 @@ VRParent* VRProcessChild::GetVRParent() {
 }
 
 bool VRProcessChild::Init(int aArgc, char* aArgv[]) {
-  if (!StaticPrefs::dom_vr_enabled() && !StaticPrefs::dom_vr_webxr_enabled()) {
-    NS_WARNING("VR is not enabled when trying to create a VRParent");
-    return false;
-  }
-
   Maybe<const char*> parentBuildID =
       geckoargs::sParentBuildID.Get(aArgc, aArgv);
   if (parentBuildID.isNothing()) {
diff --git a/testing/web-platform/meta/webvr/__dir__.ini b/testing/web-platform/meta/webvr/__dir__.ini
index bde38b749b459..d6cfe0eb08777 100644
--- a/testing/web-platform/meta/webvr/__dir__.ini
+++ b/testing/web-platform/meta/webvr/__dir__.ini
@@ -1,2 +1 @@
 prefs: [dom.vr.enabled:true, dom.vr.prompt.testing:true, dom.vr.prompt.testing.allow:true, dom.security.featurePolicy.experimental.enabled:true, dom.security.featurePolicy.header.enabled:true, dom.security.featurePolicy.webidl.enabled:true]
-leak-threshold: [vr:500]

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.
_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits