[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [metrics-lib/master] Remove unnecessary modifiers and semicolons.



commit f82e5e587817cf631e6cfcacb687cc49ea196931
Author: Karsten Loesing <karsten.loesing@xxxxxxx>
Date:   Tue Aug 21 09:23:25 2018 +0200

    Remove unnecessary modifiers and semicolons.
---
 src/main/java/org/torproject/descriptor/Method.java        |  2 +-
 src/main/java/org/torproject/descriptor/impl/Key.java      |  2 +-
 .../org/torproject/descriptor/impl/RelayDirectoryImpl.java |  2 +-
 .../torproject/descriptor/log/InternalLogDescriptor.java   | 14 +++++++-------
 4 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/main/java/org/torproject/descriptor/Method.java b/src/main/java/org/torproject/descriptor/Method.java
index 9135fe2..771fb10 100644
--- a/src/main/java/org/torproject/descriptor/Method.java
+++ b/src/main/java/org/torproject/descriptor/Method.java
@@ -5,5 +5,5 @@ package org.torproject.descriptor;
 
 /** Enum for web server access log methods. */
 public enum Method {
-    GET, HEAD, POST;
+    GET, HEAD, POST
 }
diff --git a/src/main/java/org/torproject/descriptor/impl/Key.java b/src/main/java/org/torproject/descriptor/impl/Key.java
index 602df09..f7b613f 100644
--- a/src/main/java/org/torproject/descriptor/impl/Key.java
+++ b/src/main/java/org/torproject/descriptor/impl/Key.java
@@ -156,7 +156,7 @@ public enum Key {
     keywordMap.remove(EMPTY.keyword);
   }
 
-  private Key(String keyword) {
+  Key(String keyword) {
     this.keyword = keyword;
   }
 
diff --git a/src/main/java/org/torproject/descriptor/impl/RelayDirectoryImpl.java b/src/main/java/org/torproject/descriptor/impl/RelayDirectoryImpl.java
index d87b962..5eb5b6f 100644
--- a/src/main/java/org/torproject/descriptor/impl/RelayDirectoryImpl.java
+++ b/src/main/java/org/torproject/descriptor/impl/RelayDirectoryImpl.java
@@ -357,7 +357,7 @@ public class RelayDirectoryImpl extends DescriptorImpl
         } else {
           isLive = true;
           fingerprint = ParseHelper.parseTwentyByteHexString(
-              debugLine, part.substring(1));;
+              debugLine, part.substring(1));
         }
         entry = new RouterStatusEntryImpl(fingerprint, nickname, isLive,
             isVerified);
diff --git a/src/main/java/org/torproject/descriptor/log/InternalLogDescriptor.java b/src/main/java/org/torproject/descriptor/log/InternalLogDescriptor.java
index 3c0039b..f77536e 100644
--- a/src/main/java/org/torproject/descriptor/log/InternalLogDescriptor.java
+++ b/src/main/java/org/torproject/descriptor/log/InternalLogDescriptor.java
@@ -14,14 +14,14 @@ import org.torproject.descriptor.LogDescriptor;
 public interface InternalLogDescriptor extends LogDescriptor {
 
   /** Logfile name parts separator. */
-  public static final String SEP = "_";
+  String SEP = "_";
 
   /**
    * Validate log lines.
    *
    * @since 2.2.0
    */
-  public void validate() throws DescriptorParseException;
+  void validate() throws DescriptorParseException;
 
   /**
    * Set the <code>Validator</code> that will perform the validation on log
@@ -31,31 +31,31 @@ public interface InternalLogDescriptor extends LogDescriptor {
    *
    * @since 2.2.0
    */
-  public void setValidator(Validator validator);
+  void setValidator(Validator validator);
 
   /**
    * Set the descriptor's bytes.
    *
    * @since 2.2.0
    */
-  public void setRawDescriptorBytes(byte[] bytes);
+  void setRawDescriptorBytes(byte[] bytes);
 
   /** Return the descriptor's preferred compression. */
-  public String getCompressionType();
+  String getCompressionType();
 
   /**
    * Provides a single function for validating a single log line.
    *
    * @since 2.2.0
    */
-  public interface Validator {
+  interface Validator {
 
     /**
      * Verifies a log line.
      *
      * @since 2.2.0
      */
-    public boolean validate(String line);
+    boolean validate(String line);
 
   }
 



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits