[tor-commits] [tor/master] Note a strange case for SOCKS streams.

[nickm@xxxxxxxxxxxxxx]

commit ecaeb505fab12985d314aace49f1277b1b58dc1b
Author: Mike Perry <mikeperry-git@xxxxxxxxxx>
Date:   Wed Nov 21 16:40:25 2012 -0800

    Note a strange case for SOCKS streams.
---
 src/or/connection_edge.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/or/connection_edge.c b/src/or/connection_edge.c
index a654b61..31ff900 100644
--- a/src/or/connection_edge.c
+++ b/src/or/connection_edge.c
@@ -2181,6 +2181,7 @@ connection_ap_handshake_socks_reply(entry_connection_t *conn, char *reply,
   if (status == SOCKS5_SUCCEEDED) {
     if(!conn->edge_.on_circuit ||
        !CIRCUIT_IS_ORIGIN(conn->edge_.on_circuit)) {
+      // XXX: Weird. We hit this a lot, and yet have no unusable_circs
       log_warn(LD_BUG, "No origin circuit for successful SOCKS stream");
     } else {
       TO_ORIGIN_CIRCUIT(conn->edge_.on_circuit)->any_streams_succeeded = 1;



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits