[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [obfsproxy/master] add a warning for the unwary traveller



commit 9af47b14a470aa56153ea5a42e416b19bcee7eb0
Author: Roger Dingledine <arma@xxxxxxxxxxxxxx>
Date:   Mon Feb 13 04:12:30 2012 -0500

    add a warning for the unwary traveller
    
    eventually we might want to come up with a smarter approach here.
---
 src/util.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/src/util.c b/src/util.c
index 5701d2f..608471e 100644
--- a/src/util.c
+++ b/src/util.c
@@ -495,6 +495,10 @@ log_do_debug(void)
     Accepts a logging 'severity' and a 'format' string and logs the
     message in 'format' according to the configured obfsproxy minimum
     logging severity and logging method.
+
+    Beware! Because die_oom() calls this function, we must avoid mallocing
+    any memory here, or we could get into an infinite loop. I believe it
+    is currently the case that we don't malloc anything. -RD
 */
 static void
 logv(int severity, const char *format, va_list ap)

_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits