[tor-commits] [tor/master] Note some annoyinc copy-and-paste code

[nickm@xxxxxxxxxxxxxx]

commit 869826581d01ae430b15721b0ff25ebe94103d1a
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Tue May 22 09:51:02 2012 -0400

    Note some annoyinc copy-and-paste code
---
 src/or/dirvote.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/or/dirvote.c b/src/or/dirvote.c
index d1ac8f8..96fc8a5 100644
--- a/src/or/dirvote.c
+++ b/src/or/dirvote.c
@@ -1590,6 +1590,7 @@ networkstatus_compute_consensus(smartlist_t *votes,
 
   if (consensus_method >= MIN_METHOD_TO_CLIP_UNMEASURED_BW) {
     char *max_unmeasured_param = NULL;
+    /* XXXX Extract this code into a common function */
     if (params) {
       if (strcmpstart(params, "maxunmeasuredbw=") == 0)
         max_unmeasured_param = params;
@@ -2097,6 +2098,7 @@ networkstatus_compute_consensus(smartlist_t *votes,
     // Parse params, extract BW_WEIGHT_SCALE if present
     // DO NOT use consensus_param_bw_weight_scale() in this code!
     // The consensus is not formed yet!
+    /* XXXX Extract this code into a common function */
     if (params) {
       if (strcmpstart(params, "bwweightscale=") == 0)
         bw_weight_param = params;



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits