[tor-commits] [tor/master] relay: Clarify a comment in selftest.c

[nickm@xxxxxxxxxxxxxx]

commit e887887cd32f9e78e3b6e9c47661eaf750b4c0fb
Author: teor <teor@xxxxxxxxxx>
Date:   Thu May 7 20:57:14 2020 +1000

    relay: Clarify a comment in selftest.c
---
 src/feature/relay/selftest.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/feature/relay/selftest.c b/src/feature/relay/selftest.c
index 875bf7a9f..4bbdeb3b9 100644
--- a/src/feature/relay/selftest.c
+++ b/src/feature/relay/selftest.c
@@ -255,7 +255,10 @@ router_do_reachability_checks(int test_or, int test_dir)
 
   if (router_should_check_reachability(test_or, test_dir)) {
     if (test_or && (!orport_reachable || !circuit_enough_testing_circs())) {
-      /* We'll separate IPv4 and IPv6 reachability detection in #34067. */
+      /* At the moment, tor relays believe that they are reachable when they
+       * receive any create cell on an inbound connection. We'll do separate
+       * IPv4 and IPv6 reachability checks in #34067, and make them more
+       * precise. */
       router_do_orport_reachability_checks(me, AF_INET, orport_reachable);
       router_do_orport_reachability_checks(me, AF_INET6, orport_reachable);
     }



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits