On Wed, Mar 15, 2006 at 02:17:36PM -0500, arma@xxxxxxxx wrote: > Update of /home2/or/cvsroot/tor/src/or > In directory moria:/home/arma/work/onion/cvs/tor/src/or > > Modified Files: > buffers.c connection_edge.c > Log Message: > Stop being printist: just because our local platform doesn't > consider an alleged destination to be printable doesn't mean > nobody in the world will want to use it. This patch should get reverted, I think. DNS hostname syntax is restricted to printable characters, and more specifically restricted to alphanumeric characters, hyphens, and dots. Those are considered printable *everywhere*. Although other character sets are allowed by new unicode domain name standards, they are always encoded before they're delivered to a DNS server or to us via SOCKS. Not only is the check okay, but it's useful: it protects us from the same stuff we avoid with escaped(). If we're going to take it out, we need to escape everywhere we log an address we received via socks or from another server. yrs, -- Nick Mathewson
Attachment:
pgpgxY3snvnDg.pgp
Description: PGP signature