[tor-commits] [tor/master] Fix a logic error in 4282 fixes

[nickm@xxxxxxxxxxxxxx]

commit 57e4324c425e6c9acd58c2270a183ee4d9b1e4aa
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Fri May 24 13:36:15 2013 -0400

    Fix a logic error in 4282 fixes
    
    check_or_create_data_subdir has succeeded when it returns 0, not
    when it returns negative.
---
 src/or/geoip.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/or/geoip.c b/src/or/geoip.c
index 73ad211..1c307dc 100644
--- a/src/or/geoip.c
+++ b/src/or/geoip.c
@@ -1146,7 +1146,7 @@ geoip_dirreq_stats_write(time_t now)
   str = geoip_format_dirreq_stats(now);
 
   /* Write dirreq-stats string to disk. */
-  if (check_or_create_data_subdir("stats") < 0) {
+  if (!check_or_create_data_subdir("stats")) {
     write_to_data_subdir("stats", "dirreq-stats", str, "dirreq statistics");
     /* Reset measurement interval start. */
     geoip_reset_dirreq_stats(now);



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits