[tor-commits] [tor/master] Remove dead code in test_options_validate_impl().

[nickm@xxxxxxxxxxxxxx]

commit 7344a4fdc6e9f9e4fdb6de9fe03dc73fef45c3e7
Author: Alexander Færøy <ahf@xxxxxxxxxxxxxx>
Date:   Fri May 5 17:07:18 2017 +0200

    Remove dead code in test_options_validate_impl().
    
    Dead branch found by Coverity in CID #1405875.
---
 src/test/test_options.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/test/test_options.c b/src/test/test_options.c
index d10a933..68e7ffc 100644
--- a/src/test/test_options.c
+++ b/src/test/test_options.c
@@ -187,8 +187,6 @@ test_options_validate_impl(const char *configuration,
       goto done;
   }
   tt_int_op((r == 0), OP_EQ, (msg == NULL));
-  if (r)
-    goto done;
 
   r = config_assign(&options_format, opt, cl, 0, &msg);
   if (phase == PH_ASSIGN) {



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits