[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [stem/master] Stacktrace when running individual tests



commit a09396c9ca80040fc15bae8a6ec320549d1e4f55
Author: Damian Johnson <atagar@xxxxxxxxxxxxxx>
Date:   Tue May 30 09:42:12 2017 -0700

    Stacktrace when running individual tests
    
    When running individual tests we don't trigger static checks. This in turn
    caused our recent multithreading optimization to throw a stacktrace...
    
      Traceback (most recent call last):
        File "./run_tests.py", line 457, in <module>
          main()
        File "./run_tests.py", line 331, in main
          task.join()
        File "/home/atagar/Desktop/stem/test/task.py", line 206, in join
          self.result = self._background_pipe.recv()
      AttributeError: 'NoneType' object has no attribute 'recv'
---
 test/task.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/task.py b/test/task.py
index 1c1b34e..63a9f20 100644
--- a/test/task.py
+++ b/test/task.py
@@ -202,7 +202,7 @@ class Task(object):
       self.error = exc
 
   def join(self):
-    if self._is_background_task:
+    if self._background_process:
       self.result = self._background_pipe.recv()
       self._background_process.join()
 

_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits