[tor-commits] [tor] 26/77: log_err is reserved for fatal failures

[gitolite role via tor-commits <tor-commits@xxxxxxxxxxxxxxxxxxxx>]

This is an automated email from the git hooks/post-receive script.

dgoulet pushed a commit to branch main
in repository tor.

commit ec7495d35a4f120f6e6adf1e18f2ed10df38d155
Author: Roger Dingledine <arma@xxxxxxxxxxxxxx>
AuthorDate: Fri Jul 1 17:41:21 2022 -0400

    log_err is reserved for fatal failures
---
 src/feature/hs/hs_pow.c     | 2 +-
 src/feature/hs/hs_service.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/feature/hs/hs_pow.c b/src/feature/hs/hs_pow.c
index 7507072813..49577617e6 100644
--- a/src/feature/hs/hs_pow.c
+++ b/src/feature/hs/hs_pow.c
@@ -221,7 +221,7 @@ hs_pow_verify(const hs_pow_service_state_t *pow_state,
   } else if (get_uint32(pow_state->seed_previous) == pow_solution->seed_head) {
     seed = pow_state->seed_previous;
   } else {
-    log_err(LD_REND, "Seed head didn't match either seed.");
+    log_warn(LD_REND, "Seed head didn't match either seed.");
     goto done;
   }
 
diff --git a/src/feature/hs/hs_service.c b/src/feature/hs/hs_service.c
index fe3860d05d..65f6dce2c6 100644
--- a/src/feature/hs/hs_service.c
+++ b/src/feature/hs/hs_service.c
@@ -294,7 +294,7 @@ initialize_pow_defenses(hs_service_t *service)
    * seed to be predictable even if it doesn't really exist yet, and it needs
    * to be different to the current nonce for the replay cache scrubbing to
    * function correctly. */
-  log_err(LD_REND, "Generating both PoW seeds...");
+  log_notice(LD_REND, "Generating both PoW seeds...");
   crypto_rand((char *)&pow_state->seed_current, HS_POW_SEED_LEN);
   crypto_rand((char *)&pow_state->seed_previous, HS_POW_SEED_LEN);
 
@@ -2446,7 +2446,7 @@ update_all_descriptors_pow_params(time_t now)
        * initialise pow_params in the descriptors. If this runs the next if
        * statement will run and set the correct values. */
       if (!encrypted->pow_params) {
-        log_err(LD_REND, "Initializing pow_params in descriptor...");
+        log_notice(LD_REND, "Initializing pow_params in descriptor...");
         encrypted->pow_params = tor_malloc_zero(sizeof(hs_pow_desc_params_t));
       }
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.
_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits