[tor-commits] [tor/master] Avoid mmap leak if we get a consensus diff we can't use.

[nickm@xxxxxxxxxxxxxx]

commit 18a4eaf5c142bae55780716464d43c2f8a9e2e49
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Fri Nov 2 13:30:55 2018 -0400

    Avoid mmap leak if we get a consensus diff we can't use.
    
    Fixes CID 1440819; bug not in any released Tor.
---
 src/feature/dirclient/dirclient.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/feature/dirclient/dirclient.c b/src/feature/dirclient/dirclient.c
index 705bf75e5..cd88fa5eb 100644
--- a/src/feature/dirclient/dirclient.c
+++ b/src/feature/dirclient/dirclient.c
@@ -2221,6 +2221,7 @@ handle_response_fetch_consensus(dir_connection_t *conn,
     if (!consensus_body) {
       log_warn(LD_DIR, "Received a consensus diff, but we can't find "
                "any %s-flavored consensus in our current cache.",flavname);
+      tor_munmap_file(mapped_consensus);
       networkstatus_consensus_download_failed(0, flavname);
       // XXXX if this happens too much, see below
       return -1;



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits