[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [tor/master] Fix shellcheck SC2006 warnings in 'coverage' script



commit ce1b018ab742492e96b5bdae049a13c2faaefdbf
Author: rl1987 <rl1987@xxxxxxxxxxxxxxxx>
Date:   Sun Nov 11 17:44:41 2018 +0200

    Fix shellcheck SC2006 warnings in 'coverage' script
---
 scripts/test/coverage | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/scripts/test/coverage b/scripts/test/coverage
index 59d468ee1..e611a4be1 100755
--- a/scripts/test/coverage
+++ b/scripts/test/coverage
@@ -8,19 +8,19 @@
 dst=$1
 
 for fn in src/core/*/*.c src/feature/*/*.c src/app/*/*.c src/lib/*/*.c; do
-    BN=`basename $fn`
-    DN=`dirname $fn`
-    F=`echo $BN | sed -e 's/\.c$//;'`
+    BN=$(basename $fn)
+    DN=$(dirname $fn)
+    F=$(echo $BN | sed -e 's/\.c$//;')
     GC="${BN}.gcov"
     # Figure out the object file names
-    ONS=`echo ${DN}/src_*-${F}.o`
+    ONS=$(echo ${DN}/src_*-${F}.o)
     ONS_WILDCARD_LITERAL="${DN}/src_*-${F}.o"
     # If the wildcard didn't expand, no files
     if [ "$ONS" != "${ONS_WILDCARD_LITERAL}" ]
     then
       for on in $ONS; do
         # We should have a gcno file
-        GCNO=`echo $on | sed -e 's/\.o$/\.gcno/;'`
+        GCNO=$(echo $on | sed -e 's/\.o$/\.gcno/;')
         if [ -e $GCNO ]
         then
           # No need to test for gcda, since gcov assumes no execution



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits