[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[or-cvs] [tor/master] Remember to re-install inbuf/outbuf callbacks on ssl bufferevents



Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date: Tue, 12 Oct 2010 15:48:17 -0400
Subject: Remember to re-install inbuf/outbuf callbacks on ssl bufferevents
Commit: 5710d99f00b3ac7cef0691fc9153993b0f4aa872

If we don't, we will (among other bad things) never update
lastread/lastwritten, and so flood the network with keepalives.
---
 src/or/connection_or.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/or/connection_or.c b/src/or/connection_or.c
index d63cce6..a60d437 100644
--- a/src/or/connection_or.c
+++ b/src/or/connection_or.c
@@ -914,9 +914,12 @@ connection_tls_start_handshake(or_connection_t *conn, int receiving)
     if (conn->bucket_cfg)
       bufferevent_set_rate_limit(conn->_base.bufev, conn->bucket_cfg);
     connection_enable_rate_limiting(TO_CONN(conn));
-    bufferevent_setcb(b, connection_handle_read_cb,
+
+    connection_configure_bufferevent_callbacks(TO_CONN(conn));
+    bufferevent_setcb(b,
+                      connection_handle_read_cb,
                       connection_handle_write_cb,
-                      connection_or_handle_event_cb,
+                      connection_or_handle_event_cb,/* overriding this one*/
                       TO_CONN(conn));
   }
 #endif
-- 
1.7.1